alexkachanov commented on code in PR #621: URL: https://github.com/apache/tomcat/pull/621#discussion_r1203195493
########## java/org/apache/catalina/servlets/DefaultServlet.java: ########## @@ -1650,7 +1654,7 @@ protected InputStream renderXml(HttpServletRequest request, String contextPath, .append('\''); sb.append(" urlPath='") .append(rewrittenContextPath) - .append(rewriteUrl(directoryWebappPath + entry)) + .append(rewriteUrl(directoryWebappPath + entry, URLEncoder.XML)) Review Comment: using XML encoder to encode path attribute which may contain "'" and "&" symbols -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org