greeng00se opened a new pull request, #656: URL: https://github.com/apache/tomcat/pull/656
Existing code calls getConfiguredSessionCookieName even if the context is empty. In getConfiguredSessionCookieName, only act to get the session cookie if the context is non-null. I think it's possible to avoid calling getConfiguredSessionCookieName and use Default defined by spec if context is null. It's a small optimisation, but I think it saves us one less function call. The one thing that worries me is about the Priority comment ``` // Priority is: // 1. Cookie name defined in context // 2. Cookie name configured for app // 3. Default defined by spec ``` For now, I didn't modify that part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
