Jaeyoung22 opened a new pull request, #661:
URL: https://github.com/apache/tomcat/pull/661
Although I totally agree that there could be some unnecessary parentheses to
aid the readability of the code, I think that the unity of the code is still
important for readability.
### Conditional statements of CR & LF in Http11InputBuffer
```java
// Line 445
if (prevChr == Constants.CR && chr != Constants.LF) {
// ...
}
// Line 544
} else if (prevChr == Constants.CR && chr == Constants.LF) {
// ...
}
```
Except for Line 372 that I changed, all conditional statements about CR and
LF don't have parentheses for each condition.
### Conditional statements in ChunkedInputFilter
```java
// Line 344
if (chr == Constants.CR || chr == Constants.LF) {
// ...
}
// Line 462
if (chr == Constants.CR || chr == Constants.LF) {
// ...
}
// Line 551
if (chr == Constants.CR || chr == Constants.LF) {
// ...
}
```
Except for Line 487 and 525 that I changed, all conditional statements about
constants don't have parentheses for each condition.
### Logic about space and tab in Http11InputBuffer
```java
// Line 395, 453, 974(else if)
if (chr == Constants.SP || chr == Constants.HT) {
// ...
}
// Line 419, 515, 935
if (!(chr == Constants.SP || chr == Constants.HT)) {
// ...
}
```
Because of the above codes, I tried to change Line 1001 of
Http11InputBuffer, and Line 577 of ChunkedInputFilter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
