Michael,
On 10/12/23 07:56, Michael Osipov wrote:
On 2023/10/12 11:46:55 Christopher Schultz wrote:
Michael,
On 10/12/23 06:13, micha...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 69143e32da BZ 67667: TLSCertificateReloadListener prints unreadable
rendering of X509Certificate#getNotAfter()
I'm not sure it's worth keeping the SimpleDateFormat object around after
this log statement. Consider discarding it.
I thought about it before, I decided not to:
* The listener runs in server scope, so it is always present for the lifetime
of the JVM
* The listener runs periodic task which require to create the SDF over and over
again instead of sharing it per instance
WDYT?
I forgot it runs periodically :)
Honestly, it probably doesn't matter much either way. It's not an object
that will be user frequently, so holding onto it doesn't matter. But it
also doesn't take up very much memory, so sure you can leave it.
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
