michael-o commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761175235
> Ok trying again. So the code addition in tomcat-native simply uses a file BIO to load the contents of the file and use it as a password. So overall, I do not understand the benefit of the rather significant amount of changes over simply loading the password files in the Java code and calling tomcat-native as before. I don't understand why any third party users of tomcat-native are not able to do the same as well, there's very little value add here and API compatibility seems more useful. I understand your point. It is basically for consistency with the Java code. We do also pass the path of the certificate and key to OpenSSL while we could load it in Java and pass raw bytes. This is the same. Consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
