markt-asf commented on PR #674: URL: https://github.com/apache/tomcat/pull/674#issuecomment-1776785906
Added a test key using AES128 (test passed without additional code changes). Fixed typo. Removed debug code that wasn't intended to be part of the commit. I might be persuaded to include Kerby ASN.1 although I'm not a fan of additional dependencies. We'd need to shade it if we did. Something to consider alongside the whether we want to change how we handle the Commons packages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
