aooohan commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1377262792
##########
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##########
@@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) {
}
return bytes;
}
+
+
+ private String toDottedOidString(byte[] oidBytes) {
+ try {
+ Oid oid = new Oid(oidBytes);
+ return oid.toString();
+ } catch (GSSException e) {
+ throw new IllegalArgumentException(e.getMajorString());
Review Comment:
I still think it's better to just return it, because the place where the
method is called already makes it clear where there is a problem with the OID.
(encryption algorithm with OID or pseudo random function with OID etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
