(tomcat) 08/08: Don't test lazy vs full as they can be quite close

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 3d31aab77eceba6c3efcc13d39a4d496f7bd2058
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon Jan 8 13:46:16 2024 +0000

    Don't test lazy vs full as they can be quite close
---
 test/org/apache/tomcat/util/buf/TestCharsetCachePerformance.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/org/apache/tomcat/util/buf/TestCharsetCachePerformance.java 
b/test/org/apache/tomcat/util/buf/TestCharsetCachePerformance.java
index f17098488e..0a0646db39 100644
--- a/test/org/apache/tomcat/util/buf/TestCharsetCachePerformance.java
+++ b/test/org/apache/tomcat/util/buf/TestCharsetCachePerformance.java
@@ -37,7 +37,8 @@ public class TestCharsetCachePerformance {
 
         Assert.assertTrue("No cache was faster than full cache", timeFull < 
timeNone);
         Assert.assertTrue("No cache was faster than lazy cache", timeLazy < 
timeNone);
-        Assert.assertTrue("Lazy cache was faster than full cache ", timeFull < 
timeLazy);
+        // On average full cache is faster than lazy cache but they are close 
enough the test will fail sometimes
+        //Assert.assertTrue("Lazy cache was faster than full cache ", timeFull 
< timeLazy);
     }
 
 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org