markt-asf commented on PR #700: URL: https://github.com/apache/tomcat/pull/700#issuecomment-1964174647
Fair point. The complicating factor is that there are so many entry points that a non-container thread could use. A complete solution would need to, effectively, wrap the `Response`, `Writer`, `OutputStream`, `Request`, `Reader` and `InputStream`. The resulting code would be quite messy. It should also be using `SocketWrapper.getLock()` since that is what Tomcat is using with the container threads. I'll have a think to see if I can come up with a better approach. Would you feel any differently about an approach that just targeted `Reponse.doWrite()` and `Request.doRead()` with an (optional?) lock using `SocketWrapper.getLock()`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
