markt-asf commented on PR #734: URL: https://github.com/apache/tomcat/pull/734#issuecomment-2167440923
No, it is a coding style choice. The Tomcat code uses both. Currently about 70% use `isXxx` and 30% use `getXxx`. Personally, I tend to use whichever one feels more natural at the time. `getXxx` feels more natural to me for this case. While users of the standard distribution won't notice this change (`IntrospectionUtils` will take care of it), it will break backwards compatibility for programmatic users. Any change like this needs to retain the old version with a deprecation annotation for at least the current major version before removal. There needs to be a good reason for changing the API and breaking backwards compatibility. I don't see any such reason here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
