On 25/07/2024 22:49, Rémy Maucherat wrote:
On Thu, Jul 25, 2024 at 10:34 PM Mark Thomas <ma...@apache.org> wrote:
As per Rémy's suggestion, I've been looking simplifying JreCompat to
only support LTS versions and anything more recent than the newest LTS.
That would mean:
- Tomcat 9 only
- Jre9Compat is renamed to Jre11Compat
- Tomcat 9 and 10
- Jre16Compat is renamed to Jre17Compat
- All versions
- Jre18Compat and Jre19Compat are merged into the existing Jre21Compat
Jre22Compat would be unchanged.
So the only real change is merging Jre18Compat, Jre19Compat and
Jre21Compat into a single, larger Jre21Compat.
I'm on the fence as to whether this is worth doing. Thoughts?
Changing the existing does not seem that worthwhile. I sent the idea
because adding a Java 18 class now seemed weird.
Understood. I did it that way mostly for consistency with the existing code.
The existing JreCompat implementations support a feature so it makes
(more) sense to enable the feature in as many JRE versions as possible.
This feature is a little different since there is a range of JRE
versions that support both versions of the method. On that basis, I'm
not against refactoring it to Jre21Compat and dropping Jre18Compat.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
