This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 584a6bea76 Review logging trace level: msg + exception
584a6bea76 is described below
commit 584a6bea7698d346b526aad1845939cb596e410f
Author: Mark Thomas <[email protected]>
AuthorDate: Wed Aug 20 16:23:18 2025 +0100
Review logging trace level: msg + exception
---
java/org/apache/catalina/tribes/Channel.java | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/java/org/apache/catalina/tribes/Channel.java
b/java/org/apache/catalina/tribes/Channel.java
index dad7c18c83..8c71351059 100644
--- a/java/org/apache/catalina/tribes/Channel.java
+++ b/java/org/apache/catalina/tribes/Channel.java
@@ -279,8 +279,8 @@ public interface Channel {
void start(int svc) throws ChannelException;
/**
- * Shuts down the channel. This can be called multiple times for
individual services to shut down.
- * The svc parameter can be the logical or value of any constants
+ * Shuts down the channel. This can be called multiple times for
individual services to shut down. The svc parameter
+ * can be the logical or value of any constants
*
* @param svc one of:
* <ul>
@@ -515,8 +515,10 @@ public interface Channel {
return Integer.parseInt(input);
} catch (NumberFormatException nfe) {
final Log log = LogFactory.getLog(Channel.class);
- log.trace(String.format("Failed to parse [%s] as integer,
channelSendOptions possibly set by name(s)",
- input), nfe);
+ if (log.isTraceEnabled()) {
+ log.trace(String.format("Failed to parse [%s] as integer,
channelSendOptions possibly set by name(s)",
+ input), nfe);
+ }
}
String[] options = input.split("\\s*,\\s*");
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
