All,
There are some potential API changes involved here that we might want to
revert. Therefore, I would like to reach a conclusion on the way forward
for access logs, nanoseconds and 9.0.x before the next 9.0.x tag.
Probably best for feedback to go to the PR.
Thanks,
Mark
On 24/09/2025 10:31, markt-asf (via GitHub) wrote:
markt-asf opened a new pull request, #901:
URL: https://github.com/apache/tomcat/pull/901
Adding nanosecond resolution to the access log for 9.0.x is non-trivial
because all the interface methods for access logging expect request duration to
be passed in milliseconds.
The current state of 9.0.x is that some preparatory commits have been applied that should not change the current behaviour although they do add a little overhead.
I think we have three options:
1. Don't provide nanosecond resolution to the access logs for 9.0.x. Revert
the preparatory commits.
2. Apply just the first of the commits in this PR. This is less invasive
BUT changes nearly all of the various interface methods for access logging from
milliseconds to nanoseconds. This might have backwards compatibility issues for
some users although the most likely point of extension - custom access logging
- is implemented in so that they should be compatible.
3. Apply both commits in this PR. It is more invasive but should be
backwards compatible for everyone.
Regardless of what we do with this PR, we have changed the meaning of request duration in the interface methods for access logging between 9.0.x and 10.1.x (actually 10.0.x). That decision has already been made so we just have to live with it.
If we adopt option 2 or 3, there will likely be a clean-up commit afterwards to mark various unused methods as deprecated in 9.0.x to 11.0.x and remove them in 12.0.x
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
