minjund opened a new pull request, #903:
URL: https://github.com/apache/tomcat/pull/903

   Description
   ---
   This PR made the following two modifications
   
   - Unify constant delimiters
   - Refactoring for better readability
   
   Explanation
   ---
   **Unify constant delimiters**
   Constants managed in the Constants class in the coyote package are separated 
by _ for better readability.
   
   globalCacheSize -> GLOBAL_CACHE_SIZE
   localCacheSize -> LOCAL_CACHE_SIZE
   
   **Refactoring for better readability**
   The OneLineFormatter class format() method contains thread logic. I think 
separating it into its own method would make the code easier to read. I also 
refactored the thread output into the JsonFormatter class, which extend from 
OneLineFormatter, by declaring it as protected.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to