markt-asf commented on PR #78: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/78#issuecomment-3513914715
Sorry it has taken so long. I've finally found time to review this. The current code has the concept of converted (code was changed from Java EE to Jakarta EE) and updated (version was updated in the manifest, signatures were removed from JAR files but no code changed packages). This difference only occurs in the processing of MANIFEST files. Only converted is exposed publicly. This PR changes the meaning of `Migration.hasConverted()` from "has been converted" to "has been converted or updated". That is effectively a non-backwards compatible change and I'd like to avoid such a change if possible. The PR also doesn't (quite) achieve its aim because it doesn't consider the updated case. It will end up trying to replace JARS that have been updated when it doesn't need to. I think just reverting the proposed change to ManifestConverter will achieve your aims and avoid changing the meaning of `Migration.hasConverted()`. I need to do some testing locally (and maybe wrote some unit tests) but could you test that for you use case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
