csutherl opened a new pull request, #921: URL: https://github.com/apache/tomcat/pull/921
## Summary This change introduces a Maven-style test profile system to our `build.xml` to allow for convenient, selective execution of test subsets without knowing all the class patterns to do the needful. It does this without creating any additional Ant targets that would pollute the `-projecthelp` output too. ## Usage ```bash $ ant test -Dtest.profile=smoke # Run smoke tests .... ``` ## Profiles Introduced * Smoke: uses the pattern list from ci.yml which is used as the 'smoke tests' for each PR * Catalina and Coyote: these are are not all of the components, but listed to show that it's easy to do them. If we think they're not useful they can be dropped, or if we want to cover more components we can add them. * Performance: run all performance tests * Tribes: run all tribes tests, including the old ones that are known to be flaky that are excluded by default * Buildutil: This one I only included for completeness because it is always excluded, now there's an easy way to run it if you needed to. I'd love to get some feedback on what other profiles might be useful here, or if the ones we have should be modified or eliminated. ## Changes * The `build.xml` has been updated with a new `macrodef` and two internal targets to handle the profile logic, which were added to the test* targets as a dependency. * A new `build.properties.test-profiles` file was created to store the profile pattern definitions and keep the `build.xml` easier to read. * I updated the `.github/workflows/ci.yml` to use the new profile rather than the pattern list since I used the `ci.yml` pattern to create the smoke test profile. * And lastly, added a changelog entry documenting the change to the Other subsection. The changes are fully backwards compatible by using `test.entry` takes precedence, its easy to add new profiles with a one condition needed in the `build.xml` and the profile pattern in the properties file, and the CI workflow is simplified and easier to maintain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
