I agree. Remove 1.2.24 and include all the patches.
Let's roll that ASAP.
Regards,
Mladen.
Rainer Jung wrote:
I think the problem with JK 1.2.24 is big enough to release soon. I
would also suggest to officially withdraw 1.2.24 from the download and
web site (with a comment indicating the problem) so that people will not
run into more complex problems related to the missing flush. Although
we've got no indication, that there will be a security problem, the
missing flushing can lead to undefined behaviour.
Users needed to wait for a post 1.2.23 update for 2.5 months, so 1-2
more weeks will be OK.
Additionally the question is: should we include other fixes or strictly
only 1.2.24 + this fix. If we remove 1.2.24 I think the other fixes
listed below will be safe. I would propose to include them and run
through the usual Quality check + release cycle, we've done a couple of
times for JK.
r560736 (fuankg): additional defines in jk_globalh. if __GNUC__ is
defined for WIN32 or Netware. This should enable gcc builds on these
platforms. Looks like very low risk, because until now we don't support
building with gcc on these platforms, so the change looks like it can't
break anything.
r560739 (fuankg): Change in Netware Makefile for Apache 1.3. I think
Günter knows best, if this should be released.
r560823 (rjung): changed pid_t print format detection for Solaris.
Tested with gcc and cc for 32 Bit and 64 Bit build on Solaris Sparc. Not
tested for Solaris x86, but until now I think we do not actively support
this.
r560831 (rjung): Fix nsapi crash with debug log during startup. Very
local change, low risk.
r562085 (rjung): Fix 401 problem. That's the one we definitely need.
Outstanding changes:
fail on status
--------------
http://people.apache.org/~rjung/mod_jk-dev/patches/fail-on-status.patch
Improve nsapi shut down
-----------------------
Index: netscape/jk_nsapi_plugin.c
===================================================================
--- netscape/jk_nsapi_plugin.c (revision 562051)
+++ netscape/jk_nsapi_plugin.c (working copy)
@@ -320,14 +320,15 @@
uri_worker_map_free(&uw_map, logger);
}
+ if (init_map) {
+ jk_map_free(&init_map);
+ }
+
+ jk_shm_close();
wc_close(logger);
if (logger) {
jk_close_file_logger(&logger);
}
-
- if (init_map) {
- jk_map_free(&init_map);
- }
}
Improve nsapi returning correctly when errors occur
---------------------------------------------------
Index: netscape/jk_nsapi_plugin.c
===================================================================
--- netscape/jk_nsapi_plugin.c (revision 562051)
+++ netscape/jk_nsapi_plugin.c (working copy)
@@ -382,10 +382,14 @@
}
else {
if ((result == JK_CLIENT_ERROR) && (is_error ==
JK_HTTP_OK)) {
+ rc = REQ_EXIT;
+ protocol_status(sn, rq, is_error, NULL);
jk_log(logger, JK_LOG_INFO,
"service() failed because client aborted
connection");
}
else {
+ rc = REQ_ABORTED;
+ protocol_status(sn, rq, is_error, NULL);
jk_log(logger, JK_LOG_ERROR,
"service() failed with http error %d",
is_error);
}
nsapi and shm
--------------
For Netware nsapi now has a build dependency on shm although it doesn't
use it. More generally, we need to check which way we should use shm for
nsapi on which platform. I think the nsapi and general platforms
considerations should not be done before 1.2.25, but everything else
looks OK to me.
Regards,
Rainer
Mladen Turk wrote:
[EMAIL PROTECTED] wrote:
Author: rjung
Date: Thu Aug 2 05:10:48 2007
New Revision: 562090
URL: http://svn.apache.org/viewvc?view=rev&rev=562090
Log:
Revert the quickfix r562022. It looks like we found the real problem
with r562085.
Perfect. The fix makes login working once again.
Regards,
Mladen
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
