On Fri, Jan 23, 2026 at 9:44 AM Mark Thomas <[email protected]> wrote:
>
> On 23/01/2026 07:49, Rémy Maucherat wrote:
> > On Thu, Jan 22, 2026 at 11:03 PM <[email protected]> wrote:
> >>
> >> This is an automated email from the ASF dual-hosted git repository.
> >>
> >> markt pushed a commit to branch 10.1.x
> >> in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >>
> >>
> >> The following commit(s) were added to refs/heads/10.1.x by this push:
> >>       new 85199631d1 BZ 69936: Fix for Tomcat Native crashes triggered a 
> >> memory leak
> >> 85199631d1 is described below
> >>
> >> commit 85199631d1ff9d9ef2bfeede115bc425b4a10b21
> >> Author: Mark Thomas <[email protected]>
> >> AuthorDate: Thu Jan 22 22:02:17 2026 +0000
> >>
> >>      BZ 69936: Fix for Tomcat Native crashes triggered a memory leak
> >>
> >>      Patch provided by Wes
> >>      https://bz.apache.org/bugzilla/show_bug.cgi?id=69936
> >
> > Indeed 9.0 does not need that.
> > So 9.0 did not get 0f5fee193af89af53bba72fbc6477aac74af6d6c (adding
> > ReentrantReadWriteLock getStatusLock()), do you remember why ?
>
> The clean-up mechanism is different in 9.0.x because Cleanable isn't
> available in Java 8 and finalize is deprecated in Java 9+. An equivalent
> lock was added to the destroy() method instead for 9.0.x in
> 6ea78a60b2f3e79d5b3563563a716a7c7d6b88ab

Thanks, I keep forgetting that, until I try to port the patch of course ...
I had seen the lock being added (actually, that's the only one of the
group of commits I looked at, so I had no chance to spot the '!'
issue).

Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to