This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new 376aa46d1e Add label tags to improve accessibility
376aa46d1e is described below
commit 376aa46d1e2909d96cfbf7d3352f101e2561fc83
Author: fernando murakami <[email protected]>
AuthorDate: Fri Jan 23 20:29:43 2026 -0300
Add label tags to improve accessibility
---
.../catalina/manager/HTMLManagerServlet.java | 24 +++++++++++-----------
webapps/docs/changelog.xml | 8 ++++++++
2 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/java/org/apache/catalina/manager/HTMLManagerServlet.java
b/java/org/apache/catalina/manager/HTMLManagerServlet.java
index 63aad1142f..c60ba1beb9 100644
--- a/java/org/apache/catalina/manager/HTMLManagerServlet.java
+++ b/java/org/apache/catalina/manager/HTMLManagerServlet.java
@@ -1172,34 +1172,34 @@ public class HTMLManagerServlet extends ManagerServlet {
"<table cellspacing=\"0\" cellpadding=\"3\">\n" +
"<tr>\n" +
" <td class=\"row-right\">\n" +
- " <small>{3}</small>\n" +
+ " <label for=\"deployPath\"><small>{3}</small></label>\n" +
" </td>\n" +
" <td class=\"row-left\">\n" +
- " <input type=\"text\" name=\"deployPath\" size=\"20\">\n" +
+ " <input type=\"text\" name=\"deployPath\" id=\"deployPath\"
size=\"20\">\n" +
" </td>\n" +
"</tr>\n" +
"<tr>\n" +
" <td class=\"row-right\">\n" +
- " <small>{4}</small>\n" +
+ " <label for=\"deployVersion\"><small>{4}</small></label>\n" +
" </td>\n" +
" <td class=\"row-left\">\n" +
- " <input type=\"text\" name=\"deployVersion\" size=\"20\">\n" +
+ " <input type=\"text\" name=\"deployVersion\"
id=\"deployVersion\" size=\"20\">\n" +
" </td>\n" +
"</tr>\n" +
"<tr>\n" +
" <td class=\"row-right\">\n" +
- " <small>{5}</small>\n" +
+ " <label for=\"deployConfig\"><small>{5}</small></label>\n" +
" </td>\n" +
" <td class=\"row-left\">\n" +
- " <input type=\"text\" name=\"deployConfig\" size=\"20\">\n" +
+ " <input type=\"text\" name=\"deployConfig\" id=\"deployConfig\"
size=\"20\">\n" +
" </td>\n" +
"</tr>\n" +
"<tr>\n" +
" <td class=\"row-right\">\n" +
- " <small>{6}</small>\n" +
+ " <label for=\"deployWar\"><small>{6}</small></label>\n" +
" </td>\n" +
" <td class=\"row-left\">\n" +
- " <input type=\"text\" name=\"deployWar\" size=\"40\">\n" +
+ " <input type=\"text\" name=\"deployWar\" id=\"deployWar\"
size=\"40\">\n" +
" </td>\n" +
"</tr>\n" +
"<tr>\n" +
@@ -1226,10 +1226,10 @@ public class HTMLManagerServlet extends ManagerServlet {
"<table cellspacing=\"0\" cellpadding=\"3\">\n" +
"<tr>\n" +
" <td class=\"row-right\">\n" +
- " <small>{2}</small>\n" +
+ " <label for=\"deployWarFile\"><small>{2}</small></label>\n" +
" </td>\n" +
" <td class=\"row-left\">\n" +
- " <input type=\"file\" name=\"deployWar\" size=\"40\">\n" +
+ " <input type=\"file\" name=\"deployWar\" id=\"deployWarFile\"
size=\"40\">\n" +
" </td>\n" +
"</tr>\n" +
"<tr>\n" +
@@ -1262,10 +1262,10 @@ public class HTMLManagerServlet extends ManagerServlet {
"<table cellspacing=\"0\" cellpadding=\"3\">\n" +
"<tr>\n" +
" <td class=\"row-right\">\n" +
- " <small>{3}</small>\n" +
+ " <label for=\"tlsHostName\"><small>{3}</small></label>\n" +
" </td>\n" +
" <td class=\"row-left\">\n" +
- " <input type=\"text\" name=\"tlsHostName\" size=\"20\">\n" +
+ " <input type=\"text\" name=\"tlsHostName\" id=\"tlsHostName\"
size=\"20\">\n" +
" </td>\n" +
"</tr>\n" +
"<tr>\n" +
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 7ad7d12d9e..446c345738 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -105,6 +105,14 @@
issues do not "pop up" wrt. others).
-->
<section name="Tomcat 11.0.19 (markt)" rtext="in development">
+ <subsection name="Web applications">
+ <changelog>
+ <add>
+ <bug>69931</bug>: Add <label> for fields in the HTML manager
+ application. Patch provided by yukitidev. (schultz)
+ </add>
+ </changelog>
+ </subsection>
</section>
<section name="Tomcat 11.0.18 (markt)" rtext="release in progress">
<subsection name="Coyote">
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]