rmaucher commented on PR #43: URL: https://github.com/apache/tomcat-maven-plugin/pull/43#issuecomment-3854392070
Due to some recent email activity related to the repo, I decided to have a look at it right away instead of waiting for some possible gsoc. I merged some of the code from the PR. I disagree with the design that was used though, and keep on adding new folders for each major Tomcat version. It should be possible to support all non EOL branches with only a single source folder (minus testing) since it is possible to migrate to new APIs, and in some extreme cases use reflection. Unless there's some motivation for supporting 7 and 8 with this tool (this does not make sense to me), support should be dropped, and the code can be merged back into a single folder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
