This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 4dcb357d90 Improve exception for inconsistent mapping data
4dcb357d90 is described below
commit 4dcb357d90aade3506121ac9c75006d822c9a0c3
Author: remm <[email protected]>
AuthorDate: Tue Mar 24 15:46:39 2026 +0100
Improve exception for inconsistent mapping data
---
java/org/apache/catalina/mapper/LocalStrings.properties | 1 +
java/org/apache/catalina/mapper/Mapper.java | 2 +-
java/org/apache/catalina/mapper/MappingData.java | 6 ++++++
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/java/org/apache/catalina/mapper/LocalStrings.properties
b/java/org/apache/catalina/mapper/LocalStrings.properties
index 5dcf15be74..9f2c852ca0 100644
--- a/java/org/apache/catalina/mapper/LocalStrings.properties
+++ b/java/org/apache/catalina/mapper/LocalStrings.properties
@@ -22,6 +22,7 @@ mapper.addHost.sameHost=Duplicate registration of the same
host [{0}]. Ignored.
mapper.addHost.success=Registered host [{0}]
mapper.addHostAlias.sameHost=Duplicate registration of alias [{0}] for the
same host [{1}]. Ignored.
mapper.addHostAlias.success=Registered alias [{0}] for host [{1}]
+mapper.alreadyDone=Mapping was already done on this request on [{0}]
mapper.duplicateHost=Duplicate Host [{0}]. The name is already used by Host
[{1}]. This Host will be ignored.
mapper.duplicateHostAlias=Duplicate host Alias [{0}] in Host [{1}]. The name
is already used by Host [{2}]. This Alias will be ignored.
mapper.findContext.noContext=No context found [{0}]
diff --git a/java/org/apache/catalina/mapper/Mapper.java
b/java/org/apache/catalina/mapper/Mapper.java
index b08af62890..e4f0bddce5 100644
--- a/java/org/apache/catalina/mapper/Mapper.java
+++ b/java/org/apache/catalina/mapper/Mapper.java
@@ -699,7 +699,7 @@ public final class Mapper {
// skipped all mapping work in this case. That behaviour has a risk
// of returning an inconsistent result.
// I do not see a valid use case for it.
- throw new AssertionError();
+ throw new IllegalStateException(sm.getString("mapper.alreadyDone",
mappingData));
}
// Virtual host mapping
diff --git a/java/org/apache/catalina/mapper/MappingData.java
b/java/org/apache/catalina/mapper/MappingData.java
index 6d69a1b825..44a573f46b 100644
--- a/java/org/apache/catalina/mapper/MappingData.java
+++ b/java/org/apache/catalina/mapper/MappingData.java
@@ -63,4 +63,10 @@ public class MappingData {
redirectPath.recycle();
matchType = null;
}
+
+ @Override
+ public final String toString() {
+ return "MappingData[" + host + ":" + context + ":" + wrapper + "]";
+ }
+
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
