onkar717 opened a new pull request, #976: URL: https://github.com/apache/tomcat/pull/976
## Summary This PR improves test coverage by adding unit tests for several Valve implementations that currently lack dedicated tests: - FilterValve - ProxyErrorReportValve - SemaphoreValve ## Motivation While reviewing Tomcat valve implementations, these components were identified as having little or no direct test coverage. Adding tests helps improve reliability and prevents regressions during future changes. ## Changes Added new test classes: - TestFilterValve - TestProxyErrorReportValve - TestSemaphoreValve The tests cover: - Basic initialization behavior - Request/response processing - Error handling paths - Concurrency behavior (SemaphoreValve) - Configuration edge cases ## Testing All tests pass locally using: ant clean test No existing tests were modified. ## Impact No functional changes. Test coverage improvement only. ## Notes Further opportunities may exist to improve coverage for other Valve implementations and configuration parsing logic. I plan to continue exploring these areas unless there are higher priority suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
