onkar717 opened a new pull request, #980: URL: https://github.com/apache/tomcat/pull/980
## Summary This PR improves test coverage for <ValveName> by adding tests for currently uncovered execution paths related to configuration, validation and request processing. ## Motivation During a review of Valve test coverage, several code paths were found to have limited or no direct unit tests. Adding targeted tests helps improve reliability and reduces the risk of regressions during future changes. ## Changes Added new tests covering ## Testing All tests pass locally: ## Coverage Impact This PR improves instruction coverage for <ValveName> by exercising previously untested execution paths. Some error handling branches (for example OS-level failures or rare edge conditions) are difficult to reliably reproduce in unit tests, but all realistically testable logic paths are covered. ## Impact No functional changes. Test coverage improvement only. ## Notes This PR is part of ongoing work to systematically improve test coverage for Tomcat Valve implementations. ## Checklist - [x] Tests added - [x] Build passes (ant clean test) - [x] No functional changes - [x] ASF license headers included - [x] Changes limited to test code only -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
