On Thu, Apr 23, 2026 at 8:46 PM Mark Thomas <[email protected]> wrote:

>
>
> On 23/04/2026 18:24, Dimitris Soumis wrote:
> > On Thu, Apr 23, 2026 at 8:17 PM <[email protected]> wrote:
> >
> >> This is an automated email from the ASF dual-hosted git repository.
> >>
> >> markt-asf pushed a commit to branch main
> >> in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >>
> >>
> >> The following commit(s) were added to refs/heads/main by this push:
> >>       new c45c48b294 Remove unnecessary @SuppressWarnings
> >> c45c48b294 is described below
> >>
> >> commit c45c48b29400621d5c42f4cb016485a2510ad163
> >> Author: Mark Thomas <[email protected]>
> >> AuthorDate: Thu Apr 23 18:10:34 2026 +0100
> >>
> >>      Remove unnecessary @SuppressWarnings
> >> ---
> >>   test/org/apache/catalina/valves/TestAccessLogValveFile.java | 2 --
> >>   1 file changed, 2 deletions(-)
> >>
> >> diff --git a/test/org/apache/catalina/valves/TestAccessLogValveFile.java
> >> b/test/org/apache/catalina/valves/TestAccessLogValveFile.java
> >> index 719aeb6639..f1210898c8 100644
> >> --- a/test/org/apache/catalina/valves/TestAccessLogValveFile.java
> >> +++ b/test/org/apache/catalina/valves/TestAccessLogValveFile.java
> >> @@ -55,7 +55,6 @@ public class TestAccessLogValveFile extends
> >> TomcatBaseTest {
> >>
> >>
> >>       @Test
> >> -    @SuppressWarnings("unused")
> >>       public void testRotateWithNewFileName() throws Exception {
> >>           AccessLogValve valve = createValve("access", "%s");
> >>           getTomcatInstance().start();
> >> @@ -87,7 +86,6 @@ public class TestAccessLogValveFile extends
> >> TomcatBaseTest {
> >>
> >>
> >>       @Test
> >> -    @SuppressWarnings("unused")
> >>       public void testRenameOnRotate() throws Exception {
> >>           AccessLogValve valve = createValve("access", "%s");
> >>           valve.setRotatable(true);
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [email protected]
> >> For additional commands, e-mail: [email protected]
> >>
> >>
> > I added those because Intellij was complaining about the "dir" variable
> in
> > the lambda expression.
>
> Given that the dir is required, that looks like an issue with Intellij.
>

Yeah I agree..


> Or am I missing something.
>
> It is going to be a complete pain if we can't keep the build clean in
> multiple IDEs.


> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>

Reply via email to