https://bz.apache.org/bugzilla/show_bug.cgi?id=59569

--- Comment #5 from Toby Nilsen <[email protected]> ---
Thanks for quick response. It sounds mostly correct. The main class I was
thinking about though is ProxyConnection, here:

https://github.com/apache/tomcat/blob/main/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ProxyConnection.java#L71

And here:

https://github.com/apache/tomcat/blob/main/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ProxyConnection.java#L80

The ask is for isWrapperFor to call subsequent isWrapperFor on the containing
object if it is an instance of Wrapper, and for unwrap to return the contained
objects unwrap response returned true if all else fails.

Similar to what hikaricp does here:

https://github.com/brettwooldridge/HikariCP/blob/dev/src/main/java/com/zaxxer/hikari/pool/ProxyConnection.java#L516

And here:

https://github.com/brettwooldridge/HikariCP/blob/dev/src/main/java/com/zaxxer/hikari/pool/ProxyConnection.java#L524


Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to