This is an automated email from the ASF dual-hosted git repository.
markt-asf pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 8c67d5b3be Fix persistent Windows test failures.
8c67d5b3be is described below
commit 8c67d5b3bed394e1fc41c0bf44b9decf9d8fdd10
Author: Mark Thomas <[email protected]>
AuthorDate: Fri May 1 17:16:21 2026 +0100
Fix persistent Windows test failures.
---
test/org/apache/catalina/valves/TestAccessLogValveFile.java | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/test/org/apache/catalina/valves/TestAccessLogValveFile.java
b/test/org/apache/catalina/valves/TestAccessLogValveFile.java
index 394d548536..cf749dd7ce 100644
--- a/test/org/apache/catalina/valves/TestAccessLogValveFile.java
+++ b/test/org/apache/catalina/valves/TestAccessLogValveFile.java
@@ -22,11 +22,13 @@ import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import org.junit.Assert;
+import org.junit.Assume;
import org.junit.Test;
import org.apache.catalina.Context;
import org.apache.catalina.startup.Tomcat;
import org.apache.catalina.startup.TomcatBaseTest;
+import org.apache.tomcat.util.compat.JrePlatform;
/**
* Tests for {@link AccessLogValve} file I/O, rotation, encoding, and cleanup
@@ -145,6 +147,8 @@ public class TestAccessLogValveFile extends TomcatBaseTest {
@Test
public void testCheckExists() throws Exception {
+ Assume.assumeFalse("This test cannot pass on Windows due to locking of
open files.", JrePlatform.IS_WINDOWS);
+
AccessLogValve valve = createValve("access_check", "%s");
valve.setCheckExists(true);
getTomcatInstance().start();
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
