This is an automated email from the ASF dual-hosted git repository.
rainerjung pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new bea9b2a46a Fix TestProxyErrorReportValve when test.accesslog is set
bea9b2a46a is described below
commit bea9b2a46ac41a459d03c5e2a9af0a536ca8c287
Author: Rainer Jung <[email protected]>
AuthorDate: Sat May 2 18:34:53 2026 +0200
Fix TestProxyErrorReportValve when test.accesslog is set
---
.../catalina/valves/TestProxyErrorReportValve.java | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/test/org/apache/catalina/valves/TestProxyErrorReportValve.java
b/test/org/apache/catalina/valves/TestProxyErrorReportValve.java
index 8829fa2d63..ecef467206 100644
--- a/test/org/apache/catalina/valves/TestProxyErrorReportValve.java
+++ b/test/org/apache/catalina/valves/TestProxyErrorReportValve.java
@@ -27,6 +27,7 @@ import org.junit.Assert;
import org.junit.Test;
import org.apache.catalina.Context;
+import org.apache.catalina.Valve;
import org.apache.catalina.core.StandardHost;
import org.apache.catalina.startup.Tomcat;
import org.apache.catalina.startup.TomcatBaseTest;
@@ -57,7 +58,15 @@ public class TestProxyErrorReportValve extends
TomcatBaseTest {
tomcat.start();
- ProxyErrorReportValve valve = (ProxyErrorReportValve)
host.getPipeline().getFirst();
+ ProxyErrorReportValve valve = null;
+ Valve[] valves = host.getPipeline().getValves();
+ for (Valve valveCandidate : valves) {
+ if (PROXY_VALVE.equals(valveCandidate.getClass().getName())) {
+ valve = (ProxyErrorReportValve)valveCandidate;
+ break;
+ }
+ }
+ Assert.assertNotNull(valve);
valve.setProperty("errorCode." +
HttpServletResponse.SC_INTERNAL_SERVER_ERROR,
"http://localhost:"; + getPort() + "/error-page");
@@ -83,7 +92,15 @@ public class TestProxyErrorReportValve extends
TomcatBaseTest {
tomcat.start();
- ProxyErrorReportValve valve = (ProxyErrorReportValve)
host.getPipeline().getFirst();
+ ProxyErrorReportValve valve = null;
+ Valve[] valves = host.getPipeline().getValves();
+ for (Valve valveCandidate : valves) {
+ if (PROXY_VALVE.equals(valveCandidate.getClass().getName())) {
+ valve = (ProxyErrorReportValve)valveCandidate;
+ break;
+ }
+ }
+ Assert.assertNotNull(valve);
valve.setUseRedirect(false);
valve.setProperty("errorCode." + HttpServletResponse.SC_NOT_FOUND,
"http://localhost:"; + getPort() + "/error-page");
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
