This is an automated email from the ASF dual-hosted git repository.

rainerjung pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.1.x by this push:
     new a8fecf78af Fix TestProxyErrorReportValve when test.accesslog is set
a8fecf78af is described below

commit a8fecf78af9b00b49c429e3d5529a2efa9ffffb3
Author: Rainer Jung <[email protected]>
AuthorDate: Sat May 2 18:36:33 2026 +0200

    Fix TestProxyErrorReportValve when test.accesslog is set
---
 .../catalina/valves/TestProxyErrorReportValve.java  | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/test/org/apache/catalina/valves/TestProxyErrorReportValve.java 
b/test/org/apache/catalina/valves/TestProxyErrorReportValve.java
index 861a7839cf..338ef2448e 100644
--- a/test/org/apache/catalina/valves/TestProxyErrorReportValve.java
+++ b/test/org/apache/catalina/valves/TestProxyErrorReportValve.java
@@ -26,6 +26,7 @@ import org.junit.Assert;
 import org.junit.Test;
 
 import org.apache.catalina.Context;
+import org.apache.catalina.Valve;
 import org.apache.catalina.core.StandardHost;
 import org.apache.catalina.startup.Tomcat;
 import org.apache.catalina.startup.TomcatBaseTest;
@@ -56,7 +57,15 @@ public class TestProxyErrorReportValve extends 
TomcatBaseTest {
 
         tomcat.start();
 
-        ProxyErrorReportValve valve = (ProxyErrorReportValve) 
host.getPipeline().getFirst();
+        ProxyErrorReportValve valve = null;
+        Valve[] valves = host.getPipeline().getValves();
+        for (Valve valveCandidate : valves) {
+            if (PROXY_VALVE.equals(valveCandidate.getClass().getName())) {
+                valve = (ProxyErrorReportValve)valveCandidate;
+                break;
+            }
+        }
+        Assert.assertNotNull(valve);
         valve.setProperty("errorCode." + 
HttpServletResponse.SC_INTERNAL_SERVER_ERROR,
                 "http://localhost:"; + getPort() + "/error-page");
 
@@ -82,7 +91,15 @@ public class TestProxyErrorReportValve extends 
TomcatBaseTest {
 
         tomcat.start();
 
-        ProxyErrorReportValve valve = (ProxyErrorReportValve) 
host.getPipeline().getFirst();
+        ProxyErrorReportValve valve = null;
+        Valve[] valves = host.getPipeline().getValves();
+        for (Valve valveCandidate : valves) {
+            if (PROXY_VALVE.equals(valveCandidate.getClass().getName())) {
+                valve = (ProxyErrorReportValve)valveCandidate;
+                break;
+            }
+        }
+        Assert.assertNotNull(valve);
         valve.setUseRedirect(false);
         valve.setProperty("errorCode." + HttpServletResponse.SC_NOT_FOUND,
                 "http://localhost:"; + getPort() + "/error-page");


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to