csutherl commented on code in PR #1005:
URL: https://github.com/apache/tomcat/pull/1005#discussion_r3221380589
##########
test/org/apache/catalina/storeconfig/TestStoreConfig.java:
##########
@@ -83,17 +83,23 @@ public void testListener() throws Exception {
tc_SSLHostConfig_22.addCertificate(tc_SSLHostConfigCertificate_23);
tomcat.getConnector().addSslHostConfig(tc_SSLHostConfig_22);
- org.apache.catalina.ha.tcp.SimpleTcpCluster tc_SimpleTcpCluster_51 =
new org.apache.catalina.ha.tcp.SimpleTcpCluster();
-
- org.apache.catalina.tribes.group.GroupChannel tc_GroupChannel_52 = new
org.apache.catalina.tribes.group.GroupChannel();
- ((org.apache.catalina.tribes.transport.ReceiverBase)
tc_GroupChannel_52.getChannelReceiver()).setHost("localhost");
-
- org.apache.catalina.tribes.membership.cloud.CloudMembershipService
tc_CloudMembershipService_53 =
- new
org.apache.catalina.tribes.membership.cloud.CloudMembershipService();
-
tc_CloudMembershipService_53.setMembershipProviderClassName("org.apache.catalina.tribes.membership.cloud.KubernetesMembershipProvider");
- tc_GroupChannel_52.setMembershipService(tc_CloudMembershipService_53);
- tc_SimpleTcpCluster_51.setChannel(tc_GroupChannel_52);
- tomcat.getEngine().setCluster(tc_SimpleTcpCluster_51);
+ // Clustering setup - optional, may not be available in all deployments
Review Comment:
Yeah...that's my fault. Thanks for catching that! After playing around with
it some more I see that clustering is a hard dependency all over the place and
is always required for test-compile. I'll revert that hunk, leave
TestStoreConfig alone, and cover the reflection based class inclusions in the
new TestStoreRegistry class.
I'd say moving to make clustering truly optional all the way through would
be beneficial, but I don't think it's valuable to the community as we're always
including the clustering libraries in the release deliverables :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
