On 29/06/2026 09:45, Rémy Maucherat wrote:
On Mon, Jun 29, 2026 at 10:28 AM Mark Thomas <[email protected]> wrote:
On 26/06/2026 16:06, [email protected] wrote:
This is an automated email from the ASF dual-hosted git repository.
rmaucher pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 559ff361b1 Use logout
559ff361b1 is described below
commit 559ff361b1af3690ca9109b6e62f00af2b74f4a2
Author: remm <[email protected]>
AuthorDate: Fri Jun 26 17:06:12 2026 +0200
Use logout
Logout when login does not fail but authenticate would return a null
principal.
---
java/org/apache/catalina/realm/JAASRealm.java | 5 ++---
webapps/docs/changelog.xml | 4 ++++
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/java/org/apache/catalina/realm/JAASRealm.java
b/java/org/apache/catalina/realm/JAASRealm.java
index ef6efb16ee..4acddb9f0a 100644
--- a/java/org/apache/catalina/realm/JAASRealm.java
+++ b/java/org/apache/catalina/realm/JAASRealm.java
@@ -362,9 +362,6 @@ public class JAASRealm extends RealmBase {
// Establish a LoginContext to use for authentication
try {
- if (appName == null) {
- appName = "Tomcat";
- }
Just checking why this was removed. Was it because a Realm is only ever
used inside a container and therefore appName will always be set? If so,
the configuration docs need to be updated.
This seemed like a weird hardcoded default attepmt, since setContainer
always does:
if (appName == null) {
appName = makeLegalForJAAS(container.getName());
log.info(sm.getString("jaasRealm.appName", appName));
}
As a result, I don't think this can be null. Then the hardcoded
default seems to be "other" (also a bit weird, but ok).
I suspected that was the reasoning. I'll update the docs since I don't
see how a realm can be used outside of a container.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
