sainadh777 opened a new pull request, #1044:
URL: https://github.com/apache/tomcat/pull/1044

   ## Summary
   
   - render the RewriteRule regular-expression syntax reference through 
Tomcat's existing wrapped source template
   - remove the checked-in TODO about the non-wrapping block
   - add the corresponding changelog entry
   
   ## Rationale
   
   The reference was a raw `pre` element, so it bypassed the documentation 
stylesheet's wrapped source handling. Using `source wrapped="true"` produces 
the established `codeBox` markup with `pre.wrap` and `white-space: pre-wrap`, 
allowing the content to wrap on narrow displays.
   
   ## Impact
   
   This is documentation-only. The reference text and emphasis are preserved; 
only its generated markup and narrow-display behavior change.
   
   ## Validation
   
   - `ant -q build-docs` — passed; generated `rewrite.html` contains `<pre 
class="wrap">` for the reference block
   - `ant -Dexecute.validate=true validate` — passed (Checkstyle 13.9.0, 53 
seconds)
   - `ant clean` — passed
   - `ant` — passed clean source build (23 seconds; existing deprecation, BND, 
and Java 8 source/target warnings only)
   - `git diff --check` — passed
   - `ant test -Dtest.silent=true` — stopped after 113 NIO reports to restart 
the identical unfiltered suite with the supported four-thread setting; no 
failure output before it was stopped
   - `ant test -Dtest.silent=true -Dtest.threads=4` — environment diagnostic 
run stopped after the two OpenSSL cipher classes failed because macOS 
`/usr/bin/openssl` is LibreSSL 3.3.6 and does not support `-ciphersuites`
   - `ant test -Dtest.silent=true -Dtest.threads=4 
-Dtest.openssl.path=/opt/homebrew/opt/openssl@3/bin/openssl` — passed complete 
unfiltered suite in 21 minutes 22 seconds; failed-tests list empty. The project 
skipped tests requiring unavailable Tomcat Native or other unavailable 
native/SSL facilities.
   - initial generated-distribution smoke attempt without `JAVA_HOME` — Tomcat 
did not start and no process was created; `startup.sh` reported that Java could 
not be located
   - generated-distribution smoke with 
`JAVA_HOME=/opt/homebrew/opt/openjdk/libexec/openjdk.jdk/Contents/Home` — 
passed: startup status 0, HTTP 200 from `http://127.0.0.1:8080/`, shutdown 
status 0, and process stopped cleanly
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to