This is an automated email from the ASF dual-hosted git repository.
markt-asf pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 28bc32779b Include OpenSSL version in output since that is often key
to any failure
28bc32779b is described below
commit 28bc32779b8841063a40583746a0ddd523400ac0
Author: Mark Thomas <[email protected]>
AuthorDate: Sat Oct 3 10:55:16 2026 +0100
Include OpenSSL version in output since that is often key to any failure
---
.../ciphers/TestOpenSSLCipherConfigurationParser.java | 13 ++++++-------
.../tomcat/util/net/openssl/ciphers/TesterOpenSSL.java | 4 ++++
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git
a/test/org/apache/tomcat/util/net/openssl/ciphers/TestOpenSSLCipherConfigurationParser.java
b/test/org/apache/tomcat/util/net/openssl/ciphers/TestOpenSSLCipherConfigurationParser.java
index dca5a6d34c..a7ace8f22c 100644
---
a/test/org/apache/tomcat/util/net/openssl/ciphers/TestOpenSSLCipherConfigurationParser.java
+++
b/test/org/apache/tomcat/util/net/openssl/ciphers/TestOpenSSLCipherConfigurationParser.java
@@ -539,8 +539,8 @@ public class TestOpenSSLCipherConfigurationParser {
private void testSpecificationIsEmpty(String specification) throws
Exception {
String openSSLCipherList =
TesterOpenSSL.getOpenSSLCiphersAsExpression(specification);
- Assert.assertEquals("Specification [" + specification + "] returned ["
+ openSSLCipherList +
- "] rather than the expected empty list", "",
openSSLCipherList);
+ Assert.assertEquals(TesterOpenSSL.VERSION_STRING + " with
specification [" + specification + "] returned [" +
+ openSSLCipherList + "] rather than the expected empty list",
"", openSSLCipherList);
}
@@ -557,9 +557,8 @@ public class TestOpenSSLCipherConfigurationParser {
// First check the lists have the same entries
// Order is NOT important at this point. It is checked below.
Assert.assertEquals(
- "Expected " + jsseCipherListFromOpenSSL.size() + " ciphers but
got "
- + jsseCipherListFromParser.size() + " for the
specification '"
- + specification + "'",
+ TesterOpenSSL.VERSION_STRING + " with specification [" +
specification + "] expected " +
+ jsseCipherListFromOpenSSL.size() + " ciphers but got "
+ jsseCipherListFromParser.size(),
new TreeSet<>(jsseCipherListFromOpenSSL), new
TreeSet<>(jsseCipherListFromParser));
/*
@@ -574,8 +573,8 @@ public class TestOpenSSLCipherConfigurationParser {
* be caught by CI and the test can be adjusted.
*/
if (TesterOpenSSL.VERSION > 30299) {
- Assert.assertEquals(specification,
listToString(jsseCipherListFromOpenSSL, ','),
- listToString(jsseCipherListFromParser, ','));
+ Assert.assertEquals(TesterOpenSSL.VERSION_STRING + " with
specification [" + specification + "]",
+ listToString(jsseCipherListFromOpenSSL, ','),
listToString(jsseCipherListFromParser, ','));
}
}
diff --git a/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
b/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
index 4e0e956bdb..7b88e7b819 100644
--- a/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
+++ b/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
@@ -32,6 +32,8 @@ import org.apache.catalina.util.IOTools;
public class TesterOpenSSL {
+ public static final String VERSION_STRING;
+
public static final int VERSION;
public static final Set<Cipher> OPENSSL_UNIMPLEMENTED_CIPHERS;
@@ -49,6 +51,8 @@ public class TesterOpenSSL {
} catch (IOException ioe) {
versionString = "";
}
+ VERSION_STRING = versionString;
+
// Note: Gump currently tests 12.x with OpenSSL HEAD which is
currently 4.1.x
if (versionString.startsWith("OpenSSL 4.1.")) {
VERSION = 40100;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
