This is an automated email from the ASF dual-hosted git repository.
markt-asf pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new d8c19c5867 Review "Count entries with a null value in the size of a
replicated map"
d8c19c5867 is described below
commit d8c19c586772a1594b0d946f4463ccec25950f54
Author: Mark Thomas <[email protected]>
AuthorDate: Fri Oct 23 12:14:14 2026 +0100
Review "Count entries with a null value in the size of a replicated map"
Fix containsValue() gap in null handling
Co-authored by: CoPilot / GPT-5.6 Sol
---
java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java | 3 +--
test/org/apache/catalina/tribes/tipis/TestAbstractReplicatedMap.java | 3 +++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
b/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
index 188dc74ae8..16cb45723d 100644
--- a/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
+++ b/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
@@ -1521,10 +1521,9 @@ public abstract class AbstractReplicatedMap<K, V>
@Override
public boolean containsValue(Object value) {
- Objects.requireNonNull(value);
for (Entry<K,MapEntry<K,V>> e : innerMap.entrySet()) {
MapEntry<K,V> entry = innerMap.get(e.getKey());
- if (entry != null && entry.isActive() &&
value.equals(entry.getValue())) {
+ if (entry != null && entry.isActive() && Objects.equals(value,
entry.getValue())) {
return true;
}
}
diff --git
a/test/org/apache/catalina/tribes/tipis/TestAbstractReplicatedMap.java
b/test/org/apache/catalina/tribes/tipis/TestAbstractReplicatedMap.java
index 4bd792a239..8e85d5863f 100644
--- a/test/org/apache/catalina/tribes/tipis/TestAbstractReplicatedMap.java
+++ b/test/org/apache/catalina/tribes/tipis/TestAbstractReplicatedMap.java
@@ -382,6 +382,9 @@ public class TestAbstractReplicatedMap {
Assert.assertEquals(2, map.values().size());
Assert.assertFalse(map.isEmpty());
Assert.assertTrue(map.values().contains(null));
+ Assert.assertTrue(map.containsValue(null));
+ Assert.assertTrue(map.containsValue("value"));
+ Assert.assertFalse(map.containsValue("missing"));
}
private static final class SerialKey implements Serializable {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
