dsoumis commented on code in PR #1146:
URL: https://github.com/apache/tomcat/pull/1146#discussion_r4517049667
##########
build.xml:
##########
@@ -2025,9 +2025,24 @@
<attribute name="profile"/>
<sequential>
<!-- Set test.name property based on the profile attribute -->
- <condition property="test.name" value="${test.profile.smoke}">
+
+ <!-- For the smoke profile, discover matching tests by scanning compiled
classes
+ for @Category(SmokeTest.class). The scanner outputs a
comma-separated list
+ of .java paths that feeds directly into the batchtest fileset
include pattern,
+ preserving per-test JVM isolation. -->
+ <local name="test.profile.is.smoke"/>
+ <condition property="test.profile.is.smoke">
<equals arg1="@{profile}" arg2="smoke"/>
</condition>
+ <java classname="org.apache.tomcat.categories.CategoryScanner"
Review Comment:
Run it with `fork="true"`, like the other `<java>` call in build.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
