arturobernalg opened a new pull request, #1169: URL: https://github.com/apache/tomcat/pull/1169
Adds a `responseBufferSize` attribute to the HTTP/1.1 connector. The default stays 8192 bytes, so nothing changes unless it is set. The attribute is also used for HTTP/2, which shares the connector. AJP keeps its packet based size. The value must be at least 1024. A buffer smaller than 4 bytes cannot hold a UTF-8 character, so this leaves a wide margin. `OutputBuffer.recycle()` compared the buffer capacity with `16 * defaultBufferSize` as an int, which overflows for sizes of 128 MiB or more. It now uses a long. Tests: `TestAbstractHttp11ProtocolResponseBufferSize`, `TestResponseBufferSize`. Also run against a running Tomcat with 1024, 16384 and 65536, HTTP/1.1 and HTTP/2, comparing bytes with main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
