Mark Thomas wrote:
[EMAIL PROTECTED] wrote:
+  -1: fhanik - lets not do e.printStackTrace, handle the error and log it 
correctly,

Fair point. I'll fix that.

also, have the diff only change lines that are actually changed. makes it
easier to review

Which lines do you mean? The diff looks normal to me.
pretty much all the lines before
"public class SerializablePrincipal" are non functional changes, but cosmetic.

and

-    public SerializablePrincipal()
-    {
+    public SerializablePrincipal() {
        super();
    }
+ +


and so on

Filip

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to