Filip Hanik - Dev Lists wrote: > -1 > > this is not a warning message, info or debug at best. it will only > confuse sysadmins, who are supposed to react to warn and error messages. > > There is nothing wrong with the condition where we have reached max > threads, most of the time it is fully normal. I'd say drop it down to info. > If we want to notify when we have reached max threads, I'd setup a JMX > notification instead.
I'll drop it down to info. I think debug would be too low. Mark > > Filip > > [EMAIL PROTECTED] wrote: >> Author: markt >> Date: Mon Oct 27 07:14:14 2008 >> New Revision: 708195 >> >> URL: http://svn.apache.org/viewvc?rev=708195&view=rev >> Log: >> Add warning messages to APR and NIO endpoint to match change to JIO. >> >> Modified: >> tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java >> tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java >> >> Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=708195&r1=708194&r2=708195&view=diff >> >> ============================================================================== >> >> --- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java >> (original) >> +++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Mon >> Oct 27 07:14:14 2008 >> @@ -940,6 +940,11 @@ >> } >> if ((maxThreads > 0) && (curThreads < maxThreads)) { >> curThreadsBusy++; >> + if (curThreadsBusy == maxThreads) { >> + log.warn(sm.getString("endpoint.warn.maxThreads", >> + Integer.toString(maxThreads), address, >> + Integer.toString(port))); >> + } >> return (newWorkerThread()); >> } else { >> if (maxThreads < 0) { >> >> Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=708195&r1=708194&r2=708195&view=diff >> >> ============================================================================== >> >> --- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java >> (original) >> +++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Mon >> Oct 27 07:14:14 2008 >> @@ -1074,6 +1074,11 @@ >> } >> if ((maxThreads > 0) && (curThreads < maxThreads)) { >> curThreadsBusy++; >> + if (curThreadsBusy == maxThreads) { >> + log.warn(sm.getString("endpoint.warn.maxThreads", >> + Integer.toString(maxThreads), address, >> + Integer.toString(port))); >> + } >> return (newWorkerThread()); >> } else { >> if (maxThreads < 0) { >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
