Filip Hanik - Dev Lists wrote: > Mark Thomas wrote: >> Filip Hanik - Dev Lists wrote: >> >>> As I mentioned in the bug report, what is the benefit of this? >>> >> >> General best practise - no particular bug. Note the full proposed >> patch was bad. >> > Bad practice would be to change an API, based on a report for general > practice. > It doesn't nothing but clutter the the SVN history for real bugs > next time I will veto changes like this since what one considers best > practice really merits to nothing, as it is a personal opinion and > nothing technical.
Then we disagree. I think encapsulation is a key element of good, modular software design with many technical arguments for its benefits. Whilst patches for bugs do have more immediate and obvious benefit, I don't think we should reject patches that improve the overall quality of the code, even if they don't fix actual bugs. I agree than when best practice gets as far as naming conventions, use of whitespace for indenting, line length and other coding style issues then you are into the realm of personal opinion and with a few notable exceptions (such as converting tabs to spaces) then there is little to be gained. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
