Author: fhanik
Date: Wed Jun 10 23:57:09 2009
New Revision: 783583
URL: http://svn.apache.org/viewvc?rev=783583&view=rev
Log:
votes
Modified:
tomcat/current/tc5.5.x/STATUS.txt
Modified: tomcat/current/tc5.5.x/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=783583&r1=783582&r2=783583&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Wed Jun 10 23:57:09 2009
@@ -31,7 +31,7 @@
text replacement hack as part of the EL processing.
http://people.apache.org/~markt/patches/2009-01-01-bug36923.patch
*NOTE* Following patch is also required to prevent regression as per bug
47318
- +1: markt, kkolinko
+ +1: markt, kkolinko, fhanik
-1:
* Patch to prevent regression with above fix for 36923 (ie bug 47318)
@@ -45,7 +45,7 @@
http://people.apache.org/~markt/patches/2009-02-04-bug38483.patch
+1: markt, rjung
+1: kkolinko (ok, but I propose an additional patch below)
- -1:
+ -1: fhanik - sounds like a use case for ThreadLocal, synchronized this on a
valve is bad
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38483
Make access log valves thread safe (part 2)
@@ -55,7 +55,8 @@
long assignments are not atomic. (see Java Language Specification 3rd ed,
ch. 17.7)
http://people.apache.org/~kkolinko/patches/2009-06-07_bug38483_2.patch
+1: kkolinko
- -1:
+ -1: fhanik - I don't see how this is more thread safe than before.
+ A thread can still call writer.println(message) while another
thread has called close() but not yet open
* Fix use of setLoopbackMode() for tribes multicast.
in
container/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java
@@ -68,7 +69,7 @@
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44382
Port httpOnly support from 6.0.x
https://issues.apache.org/bugzilla/attachment.cgi?id=23497
- +1: markt, rjung
+ +1: markt, rjung, fhanik
-1:
* Fix locking in cluster/tcp/FastAsyncSocketSender:
@@ -85,7 +86,7 @@
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46552
Return a 400 rather than a 200 if headers are too large
http://people.apache.org/~markt/patches/2009-04-09-bug46552.patch
- +1: markt, kkolinko
+ +1: markt, kkolinko, fhanik
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46384
@@ -101,7 +102,7 @@
For zip/tgz distributives it was already fixed in 6.0.17, 5.5.27.
Now, apply the same fix to exe distributive.
http://svn.apache.org/viewvc?rev=776945&view=rev
- +1: kkolinko
+ +1: kkolinko, fhanik
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43343
@@ -109,18 +110,18 @@
http://svn.apache.org/viewvc?rev=656751&view=rev (case A fix)
http://svn.apache.org/viewvc?rev=778523&view=rev (prerequisite)
http://svn.apache.org/viewvc?rev=778524&view=rev (case B fix)
- +1: markt
+ +1: markt, fhanik
-1:
* Fix wrong download location of tcnative 1.1.16
Patch for "build/build.properties.default":
http://people.apache.org/~kkolinko/patches/2009-05-25_fix_tcnative_download.patch
- +1: kkolinko
+ +1: kkolinko, fhanik
-1:
* Make 64-bit binaries/installer available for 5.5.x as well as 6.0.x
http://svn.apache.org/viewvc?rev=777624&view=rev
- +1: markt
+ +1: markt, fhanik
-1:
kkolinko: good, but needs an amendment, because some files were deleted in
http://svn.apache.org/viewvc?view=rev&revision=779927
@@ -130,7 +131,7 @@
This is partial backport of
http://svn.apache.org/viewvc?view=rev&revision=673614
Also, update to NSIS 2.44
http://people.apache.org/~kkolinko/patches/2009-06-03_nsis-download-tc55.patch
- +1: kkolinko
+ +1: kkolinko, fhanik
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47316
@@ -138,11 +139,11 @@
name != engine name
This is a regression caused by the fix for bug 42707
https://issues.apache.org/bugzilla/attachment.cgi?id=23764
- +1: markt, kkolinko
+ +1: markt, kkolinko, fhanik
-1:
* Use a more senaible default for appBase
http://svn.apache.org/viewvc?rev=782791&view=rev
Patch by Ian Darwin
- +1: markt, kkolinko
+ +1: markt, kkolinko, fhanik
-1:
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
