Author: fhanik
Date: Wed Jun 17 21:39:26 2009
New Revision: 785818
URL: http://svn.apache.org/viewvc?rev=785818&view=rev
Log:
clarifications
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=785818&r1=785817&r2=785818&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Jun 17 21:39:26 2009
@@ -167,9 +167,11 @@
good, but
1. Why such short implementation for JIoEndpoint, AprEndpoint and
such elaborated one for NioEndpoint?
+fhanik: NioEndpoint only uses Executors, it's removed the 'synchronized' based
thread pool.
Is there a reason why JIoEndpoint, AprEndpoint are not
implemented in the same way?
+fhanik: there was a notion that the Tomcat thread pool was faster, hence the
old one is still there
2. Http11Processor calls JIoEndpoint.getCurrentThreadsBusy():
@@ -178,6 +180,7 @@
The threadRatio value will be negative, if the patch is applied as
is. Well, that makes no much difference from zero value w/o the patch.
+fhanik: That is a great point, This is an important observations that warrants
another patch, independent of this one
)
* Fix download task dependency for commons-pool and commons-dbcp.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
