Author: markt
Date: Thu Jun 18 08:52:01 2009
New Revision: 785961
URL: http://svn.apache.org/viewvc?rev=785961&view=rev
Log:
Add some comments re thread safety
Modified:
tomcat/current/tc5.5.x/STATUS.txt
Modified: tomcat/current/tc5.5.x/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=785961&r1=785960&r2=785961&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Thu Jun 18 08:52:01 2009
@@ -45,6 +45,9 @@
+1: markt, rjung
+1: kkolinko (ok, but I propose an additional patch below)
-1: fhanik - sounds like a use case for ThreadLocal, synchronized this on a
valve is bad
+ markt - This is post response having been sent to the client so the
syncs are less of
+ an issue. Further, the micro-benchmarks suggests that the syncs
are a little
+ quicker.
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38483
Make access log valves thread safe (part 2)
@@ -56,6 +59,11 @@
+1: kkolinko
-1: fhanik - I don't see how this is more thread safe than before.
A thread can still call writer.println(message) while another
thread has called close() but not yet open
+ markt - Strictly, the sync is required to protect access to the
fileDateFormatter object
+ Based on the microbenchmarks for the other syncs, I suspect a
sync here will be
+ faster than a ThreadLocal.
+ The patch appears to use tabs rather than spaces
+ The issue Filip identified with writing messages when the file
is being rotated is still an issue
* Fix use of setLoopbackMode() for tribes multicast.
in
container/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
