Konstantin Kolinko wrote: > 2009/6/23 <ma...@apache.org> >> Author: markt >> Date: Tue Jun 23 12:00:14 2009 >> New Revision: 787648 >> >> URL: http://svn.apache.org/viewvc?rev=787648&view=rev >> Log: >> Improved, single patch >> >> +* Make diagnosing broken requests a little easier. >> + http://people.apache.org/~markt/patches/2009-06-23-parameters.patch >> > > I'm sorry to bother: > > The following line in the first part of the patch: > > msg.append(new String(bytes, nameStart, valEnd - nameStart)); > > This String constructor will use the platform default encoding. > I suppose it should be ISO-8859-1 here?
Yes, and elsewhere in the class. I'll make the changes. > Also > + ByteChunk origName=new ByteChunk(); > + ByteChunk origValue=new ByteChunk(); > can be 'private' here. Agreed. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
