Rainer Jung wrote: > On 23.09.2009 13:12, Mark Thomas wrote: >> rj...@apache.org wrote: >>> * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47267 >>> http://svn.apache.org/viewvc?rev=817822&view=rev >>> +1: markt >>> -1: >>> + rjung: Our dreaded multi platform build system is a bit fragile >>> + w.r.t. fixcrlf. If you change the file to crlf in the installer >>> + target, then all unix packages (which are build after installer) >>> + will also contain it in crlf format. Not to bad for especially >>> + that file (because part of a webapp), but maybe it would >>> + be cleaner to do this for the installer target only, e.g. >>> + saving the file, fixcrlf, run nsi, restoring file. >> Are you sure? There looks to be a fixcrlf at the beginning of each of >> the zip and tar.gz packaging targets which should fix that. > > I thought so to, but I tested it :)
That always helps :) It doesn't really matter for webapps and we do just leave the files with whatever line ending they had when the files were built. I'll look at completely re-doign this for Tomcat 7. I think Sebb proposed a patch somewhere that will probably help. > I guess, the *.txt pattern in those fixcrlf applies only to top level, > no **/ there. But somehow I think it would be safer to let the installer > fixcrlf not have a side effect one needs to clean up in other places. > > Well ... I see where you are coming from. I'll take a lok at Tomcat 7 and then we can figure out what to port back, if anything. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
