That looks better - will incorporate that. On the configuration I went for two properties with the same names as the Httpd rotatelogs params. The rotationtime option is identical in interpretation, and the filesize option doesn't have a trailing M as for rotatelogs (no need in our context, although we could handle it).
cheers tim ----- Original Message ----- From: "Mladen Turk" <mt...@apache.org> To: "Tomcat Developers List" <dev@tomcat.apache.org> Sent: Thursday, 7 January, 2010 10:26:13 PM GMT +12:00 New Zealand Subject: Re: [PROPOSAL] Log rotation in Tomcat Connector On 01/07/2010 09:56 AM, Tim Whittington wrote: > I've attached the initial implementation, along with a docs patch, to an > issue in Bugzilla. > https://issues.apache.org/bugzilla/show_bug.cgi?id=48501 > > I managed to track down the crashing - I was referencing a jk_file_logger_t > that got deallocated when the log rotated, which IIS didn't like at all. > If you fix the MSVCRT80 dependency I have no problem with the patch. However the configuration should be as close to the Httpd's logrotate as possible. For _ftell_nolock I'd use LARGE_INTEGER li; HANDLE h = (HANDLE)_get_osfhandle(fileno(logfile)) GetFilesizeEx(h, &li) if (li.QuadPart ... ) _ftell_nolock has two drawbacks 1. Does not exist in MSVCRT.dll 2. It works for < 2GB files Regards -- ^TM --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
