Author: rjung
Date: Thu Mar 4 14:32:05 2010
New Revision: 918998
URL: http://svn.apache.org/viewvc?rev=918998&view=rev
Log:
Vote, comment.
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=918998&r1=918997&r2=918998&view=diff
==============================================================================
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Thu Mar 4 14:32:05 2010
@@ -37,7 +37,7 @@
Reuses StringBuffer, uses char instead of single-char String, etc.
http://people.apache.org/~kkolinko/patches/2009-07-15_tc55_ALV.patch
http://people.apache.org/~kkolinko/patches/2009-07-15_tc55_FCALV.patch
- +1: kkolinko
+ +1: kkolinko, rjung
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42390
@@ -55,6 +55,7 @@
kkolinko: To reviewers: the patch looks scary, but the only thing it
actually does is to add "synchronized (name.intern()) {" around the
whole contents of the method.
+ rjung: Isn't there a possibility for deadlocks?
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47878
Return 404's rather than a permanent 500 if a JSP is deleted
@@ -70,19 +71,21 @@
Also removes some old commented-out code and changes some message strings.
This patch file is a backport of revs. 834047, 836036, 836045, 836209
http://people.apache.org/~kkolinko/patches/2009-11-14_Installer_password_tc55.patch
- +1: kkolinko, markt
+ +1: kkolinko, markt, rjung
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48322
Single quote should be not be treated as a separator
http://svn.apache.org/viewvc?rev=830999&view=rev
- +1: markt, kkolinko
+ +1: markt, kkolinko, rjung
-1:
* Provide new option to allow = in cookie values
http://people.apache.org/~markt/patches/2009-11-17-cookie-allow-equals.patch
- +1: markt, kkolinko
+ +1: markt, kkolinko, rjung
-1:
+ rjung: it might be more reader friendly to explicitely add parentheses when
+ having || and && mixed in the same logical expression (see the "while" loop).
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47609
Implement fail-safe EOL conversion for source distributions
@@ -91,7 +94,7 @@
files used in storeconfig[-ha] module tests become broken in the -src.tar.gz
bundle.
http://people.apache.org/~kkolinko/patches/2010-01-05_tc55_bug47609.patch
- +1: kkolinko, markt
+ +1: kkolinko, markt, rjung
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47997
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
