2010/3/6 Mark Thomas <[email protected]>: > On 06/03/2010 14:48, [email protected] wrote: >> Author: kkolinko >> Date: Sat Mar 6 14:48:02 2010 >> New Revision: 919772 >> >> URL: http://svn.apache.org/viewvc?rev=919772&view=rev >> Log: >> proposal >> >> Modified: >> tomcat/tc5.5.x/trunk/STATUS.txt >> >> Modified: tomcat/tc5.5.x/trunk/STATUS.txt >> URL: >> http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=919772&r1=919771&r2=919772&view=diff >> ============================================================================== >> --- tomcat/tc5.5.x/trunk/STATUS.txt (original) >> +++ tomcat/tc5.5.x/trunk/STATUS.txt Sat Mar 6 14:48:02 2010 >> @@ -90,3 +90,18 @@ >> (it is markt's r915070) >> +1: kkolinko >> -1: >> + >> +* Remove JSSE13Factory, JSSE13SocketFactory classes, >> + because >> + - TC 5.5 runs on JRE 1.4+ and that comes bundled with JSSE 1.4, >> + so these classes are no more needed. >> + - JSSE13SocketFactory directly references com.sun.net.* classes in its >> + source code without using reflection, and that causes compilation >> failure >> + with my IDE/JRE settings. >> + 1) >> + svn delete >> connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE13Factory.java >> + svn delete >> connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE13SocketFactory.java >> + 2) >> + >> http://people.apache.org/~kkolinko/patches/2010-03-06_tc55_remove_JSSE13Factory.patch >> + +1: kkolinko >> + -1: > > Unless I am missing something, you can also remove the whole of the > if(factory == null && JdkCompat.isJava14()){...} block in > JSSEImplementation as well. >
Yes, you are right, we can remove that. I updated the patch. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
