svn commit: r993096 - /tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java

[markt]

Author: markt
Date: Mon Sep  6 16:53:34 2010
New Revision: 993096

URL: http://svn.apache.org/viewvc?rev=993096&view=rev
Log:
Reduce visibility, remove unused/unnecessary methods prior to fixing bz49884

Modified:
    tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java

Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=993096&r1=993095&r2=993096&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Mon Sep  6 
16:53:34 2010
@@ -101,7 +101,7 @@ public class AsyncContextImpl implements
 
     @Override
     public void dispatch() {
-        HttpServletRequest sr = (HttpServletRequest)getServletRequest();
+        HttpServletRequest sr = (HttpServletRequest)getRequest();
         String path = sr.getRequestURI();
         String cpath = sr.getContextPath();
         if (cpath.length()>1) path = path.substring(cpath.length());
@@ -171,12 +171,12 @@ public class AsyncContextImpl implements
 
     @Override
     public ServletRequest getRequest() {
-        return getServletRequest();
+        return servletRequest;
     }
 
     @Override
     public ServletResponse getResponse() {
-        return getServletResponse();
+        return servletResponse;
     }
 
     @Override
@@ -277,14 +277,6 @@ public class AsyncContextImpl implements
         }
     }
 
-    public ServletRequest getServletRequest() {
-        return servletRequest;
-    }
-
-    public ServletResponse getServletResponse() {
-        return servletResponse;
-    }
-
     @Override
     public boolean hasOriginalRequestAndResponse() {
         return hasOriginalRequestAndResponse;
@@ -294,11 +286,7 @@ public class AsyncContextImpl implements
         this.hasOriginalRequestAndResponse = hasOriginalRequestAndResponse;
     }
 
-    public boolean isCompleted() {
-        return (state.get()==AsyncState.NOT_STARTED);
-    }
-
-    public void doInternalDispatch() throws ServletException, IOException {
+    protected void doInternalDispatch() throws ServletException, IOException {
         if (this.state.compareAndSet(AsyncState.TIMING_OUT,
                 AsyncState.TIMING_OUT_NEED_COMPLETE)) {
             log.debug("TIMING OUT!");
@@ -360,8 +348,8 @@ public class AsyncContextImpl implements
         }
     }
     
-    public void doInternalComplete(boolean error) {
-        if (isCompleted()) return;
+    private void doInternalComplete(boolean error) {
+        if (state.get()==AsyncState.NOT_STARTED) return;
         if (state.compareAndSet(AsyncState.STARTED, AsyncState.NOT_STARTED)) {
             //this is the same as
             //request.startAsync().complete();
@@ -392,10 +380,6 @@ public class AsyncContextImpl implements
         return state.get();
     }
     
-    protected void setState(AsyncState st) {
-        state.set(st);
-    }
-    
     @Override
     public long getTimeout() {
         return timeout;



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org