> From: Mark Thomas [mailto:[email protected]]
> Subject: Re: svn commit: r1041892 - in /tomcat/trunk:
> java/org/apache/catalina/connector/test/org/apache/
> catalina/connector/ webapps/docs/ webapps/docs/config/
> > + public String getParseBodyMethods()
> > + {
> > + return (this.parseBodyMethods);
> > + }
> The Tomcat code style is to have brackets at the end of the previous line.
And there's no reason to put parentheses around a return value.
> > + if(methodSet.contains("TRACE"))
> > + throw new IllegalArgumentException("TRACE method MUST NOT
> > include an entity (see RFC 2616 Section 9.6)");
> This should use the StringManager for i18n support.
Also needs a space after the if.
Is there a convention for line length, and how to handle long constant strings
that aren't controlled by the StringManager?
- Chuck
THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY
MATERIAL and is thus for use only by the intended recipient. If you received
this in error, please contact the sender and delete the e-mail and its
attachments from all computers.
