On 17/12/2010 08:49, Konstantin Kolinko wrote: > 2010/12/16 Christopher Schultz <ch...@christopherschultz.net>: >> All, >> >> I'm looking at writing a patch for bug 50234 ("JspC use servlet 3.0 >> features": https://issues.apache.org/bugzilla/show_bug.cgi?id=50234) and >> I'm thinking that the annotations should actually have nothing to do >> with the precompiler, but the compiler itself. >> >> Can anyone think of a reason not to simply update >> jasper.compiler.Generator to add the @WebServlet annotations? I believe >> everything else needs to be handled by JspC. >> > > Note, that you still have to preserve compatibility for the webapps > that adhere to Servlet 2.5 and earlier versions of specification. > > Using JspC may be limited to Servlet 3.0+ ones (if it is worth it), > but just deploying earlier versions of the webapps on Tomcat should > still work.
JspC should know which spec version is defined in web.xml, so could switch behaviour. > Do you really need @WebServlet here? Are the jsp servlets discovered > though annotations, or do you list them in web-fragment.xml ? Does Tomcat automatically discover classes annotated with @WebServlet, or must they be included in a JAR, with a web-fragment.xml? I though the latter only. p
0x62590808.asc
Description: application/pgp-keys
signature.asc
Description: OpenPGP digital signature