Author: markt
Date: Sun May  8 22:11:19 2011
New Revision: 1100825

URL: http://svn.apache.org/viewvc?rev=1100825&view=rev
Log:
Fix Servlet TCK failures with using the RemoteIpValve

Modified:
    tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java
    tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java?rev=1100825&r1=1100824&r2=1100825&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java Sun May  8 
22:11:19 2011
@@ -442,6 +442,17 @@ public class RemoteIpValve extends Valve
      */
     private Pattern trustedProxies = null;
     
+
+    /**
+     * Default constructor that ensures {@link ValveBase#ValveBase(boolean)} is
+     * called with <code>true</code>.
+     */
+    public RemoteIpValve() {
+        // Async requests are supported with this valve
+        super(true);
+    }
+
+    
     public int getHttpsServerPort() {
         return httpsServerPort;
     }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1100825&r1=1100824&r2=1100825&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Sun May  8 22:11:19 2011
@@ -53,6 +53,10 @@
         Ensure that the SSLValve provides the SSL key size as an Integer rather
         than a String. (markt)
       </fix>
+      <fix>
+        Ensure that the RemoteIpValve works correctly with Servlet 3.0
+        asynchronous requests. (markt)
+      </fix>
     </changelog>
   </subsection>
 </section>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to